Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove math module from count #32725

Merged
merged 1 commit into from Apr 26, 2018
Merged

Conversation

nikolai-b
Copy link
Contributor

Not required after rails/arel#449

There is a test showing it isn't needed here:
https://github.com/rails/rails/blob/master/activerecord/test/cases/arel/nodes/count_test.rb#L36-L42

Copied over from rails/arel#525

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Copy link

@sinsys1981 sinsys1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@kamipo kamipo merged commit 2929d16 into rails:master Apr 26, 2018
@nikolai-b nikolai-b deleted the rm_count_math_mixin branch April 26, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants