Remove confusion in the sentence [ci skip] #32818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eileencodes (@rails-bot has picked a reviewer for you, use r? to override) |
|
That reads much better, thanks! |
fxn
added a commit
that referenced
this pull request
May 6, 2018
Once all technicalities have been introduced, the purpose of this
paragraph is to precisely unroll expressions like "the String class".
That way, the reader is forced to clearly separate concepts that Ruby
programmers often have kind of blurred:
* Constants are storage, like variables.
* Ruby does not have syntax for class or module names.
* `String` is a regular constant that holds a value. In this case, the
value happens to be a class object.
* Constants are stored in class and module objects. In the case of
`String`, the holder is the class object stored in the `Object`
constant.
Understanding that paragraph the way is written is important to
accomplish this objective.
References #32818.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove confusion in the sentence.