Added a lot of Oxford commas #32849
Added a lot of Oxford commas #32849
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| @@ -323,7 +323,7 @@ Validations | |||
|
|
|||
| Active Record allows you to validate the state of a model before it gets written | |||
| into the database. There are several methods that you can use to check your | |||
| models and validate that an attribute value is not empty, is unique and not | |||
| models and validate that an attribute value is not empty, is unique, and not | |||
There was a problem hiding this comment.
✂️
This is correctly a compound item; the missing comma is on the next line.
| @@ -348,7 +348,7 @@ by asking the debugger for help. Type: `help` | |||
| break -- Sets breakpoints in the source code | |||
| catch -- Handles exception catchpoints | |||
| condition -- Sets conditions on breakpoints | |||
| continue -- Runs until program ends, hits a breakpoint or reaches a line | |||
| continue -- Runs until program ends, hits a breakpoint, or reaches a line | |||
There was a problem hiding this comment.
✂️
We can't editorialize on byebug's output 😄
| @@ -365,7 +365,7 @@ by asking the debugger for help. Type: `help` | |||
| irb -- Starts an IRB session | |||
| kill -- Sends a signal to the current process | |||
| list -- Lists lines of source code | |||
| method -- Shows methods of an object, class or module | |||
| method -- Shows methods of an object, class, or module | |||
| @@ -575,7 +575,7 @@ Let's have `byebug` help us with it. | |||
| Shows variables and its values | |||
|
|
|||
|
|
|||
| var all -- Shows local, global and instance variables of self. | |||
| var all -- Shows local, global, and instance variables of self. | |||
|
@matthewd Thanks for the feedback. I made changes as per your comments. |
[ci skip] A regular expression was used to find a lot of missing Oxford
commas and add them. The regular expression was as follows.
", ([a-zA-Z0-9.\`:'\"]+ ){1,6}(or|and) "
anthonycrumley
force-pushed
the
oxford-commas
branch
from
66015c7
to
2586702
Compare
|
@matthewd This is now squashed down to one commit. 👍 |
|
@matthewd For code change responses to comments on a pull request, does the Rails team find it easier to review a separate commit that is later squashed or an amendment of the original commit? Thanks for your feedback. 😄 |
|
Personally, I'd say it depends whether the change is short enough, or has changed so much, that re-reading the full diff is the easiest way to review it -- in which case pre-squashing saves a back-and-forth. In a case like this, it was much easier for me to initially review as an additional commit. 👍 |
A regular expression was used to find a lot of missing Oxford
commas and add them. The regular expression was as follows.
", ([a-zA-Z0-9.`:'"]+ ){1,6}(or|and) "