Ensure that the directory 'vendor/assets/javascripts' is created by AppGenerator #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2011 17:04
… called within vendor method
|
Hi @josevalim, would you please review this pull request. |
josevalim
added a commit
that referenced
this pull request
Oct 12, 2011
…ld_be_created Ensure that the directory 'vendor/assets/javascripts' is created by AppGenerator
|
Not sure why this is removed from here d9c39c3 |
|
Looks like @fxn accidentally removed the |
|
The method was removed because jQuery was provided via the asset pipeline and its primary purpose was to generate the files. But it was an oversight not to create the directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directory 'vendor/assets/javascripts' is referenced in
railties/lib/rails/generators/rails/app/templates/app/assets/javascripts/application.js.tt, but isn't actually created as part of the generator suites.I've added a method to the AppGenerator class and a relevant test to ensure this directory is created.