Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active storage: Image variant options not correct in docs #32916

Merged
merged 1 commit into from May 17, 2018

Conversation

lucfranken
Copy link
Contributor

Steps to reproduce

Using Rails 5.2.0

When following this example:

http://api.rubyonrails.org/classes/ActiveStorage/Variant.html

avatar.variant(resize: "100x100", monochrome: true, flip: "-90")

Expected behavior

Image should be rendered as rotated.

Actual behavior

I get an error:

failed with error: gm mogrify: Unrecognized option (-90).

Fix:

According to: https://github.com/minimagick/minimagick the option should be called rotate:

avatar.variant(resize: "100x100", monochrome: true, rotate: "-90")

So flip changed to rotate.

System configuration

Rails version: 5.2.0

Ruby version: ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]

[ci skip]

### Steps to reproduce

Using Rails 5.2.0

When following this example:

http://api.rubyonrails.org/classes/ActiveStorage/Variant.html

`avatar.variant(resize: "100x100", monochrome: true, flip: "-90")`

### Expected behavior

Image should be rendered as flipped.

### Actual behavior

I get an error:

> failed with error: gm mogrify: Unrecognized option (-90).

### Fix:

According to: https://github.com/minimagick/minimagick the option should be called rotate:

`avatar.variant(resize: "100x100", monochrome: true, rotate: "-90")`

So **flip** changed to **rotate**.

### System configuration
**Rails version**: 5.2.0

**Ruby version**: ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@lucfranken lucfranken changed the title Active storage: Image variant options not correct Active storage: Image variant options not correct in docs May 17, 2018
@kamipo kamipo merged commit e77c516 into rails:master May 17, 2018
@kamipo
Copy link
Member

kamipo commented May 17, 2018

Thanks!

kamipo added a commit that referenced this pull request May 17, 2018
Active storage: Image variant options not correct in docs

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants