Active storage: Image variant options not correct in docs #32916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
Using Rails 5.2.0
When following this example:
http://api.rubyonrails.org/classes/ActiveStorage/Variant.html
avatar.variant(resize: "100x100", monochrome: true, flip: "-90")
Expected behavior
Image should be rendered as rotated.
Actual behavior
I get an error:
Fix:
According to: https://github.com/minimagick/minimagick the option should be called rotate:
avatar.variant(resize: "100x100", monochrome: true, rotate: "-90")
So flip changed to rotate.
System configuration
Rails version: 5.2.0
Ruby version: ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]
[ci skip]