Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct default value of unknown_asset_fallback #33053

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

lazyatom
Copy link
Contributor

@lazyatom lazyatom commented Jun 4, 2018

Rails.application.config.assets.unknown_asset_fallback now defaults to false in an unmodified Rails application, but the guides say it defaults to true. This commit fixes the guide.

Summary

The default value of this configuration option is false; I believe this is true as of Rails 5.1, and certainly is in Rails 5.2; this was verified by generating a new Rails application, and running the following in a development console:

Rails.application.config.assets.unknown_asset_fallback => false
Sprockets::Railtie.config.assets.unknown_asset_fallback # => false
ActionView::Base.unknown_asset_fallback # => false

The setting of this value can be seen here:

assets.unknown_asset_fallback = false

`Rails.application.config.assets.unknown_asset_fallback` now defaults to `false` in an unmodified Rails application.

[ci skip]
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kamipo kamipo merged commit 187ace0 into rails:master Jun 4, 2018
kamipo added a commit that referenced this pull request Jun 4, 2018
Correct default value of `unknown_asset_fallback`

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants