Convert hashes into parameters #33076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
reviewed
Jun 7, 2018
| @@ -1,7 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require "abstract_unit" | |||
| require "action_controller/metal/strong_parameters" | |||
| require_relative "../../../lib/action_controller/metal/strong_parameters" | |||
There was a problem hiding this comment.
@simi it's not. I was a bit too fast with pushing my changes. I've updated the commit accordingly.
Ensure `ActionController::Parameters#transform_values` and `ActionController::Parameters#transform_values!` converts hashes into parameters.
hovsater
force-pushed
the
strong-parameters/transform-values
branch
from
db3cb12
to
90b5fb6
Compare
rafaelfranca
reviewed
Jun 8, 2018
| @@ -640,19 +640,17 @@ def extract!(*keys) | |||
| # params.transform_values { |x| x * 2 } | |||
| # # => <ActionController::Parameters {"a"=>2, "b"=>4, "c"=>6} permitted: false> | |||
| def transform_values(&block) | |||
There was a problem hiding this comment.
Can you remove the block variable now that it is no used?
There was a problem hiding this comment.
I can. I deliberately left it there since the other method signatures seemed to keep it even though they called the block implicitly.
There was a problem hiding this comment.
@rafaelfranca see cb17cb2.
|
@sikachu @rafaelfranca is this good to go? |
rafaelfranca
pushed a commit
that referenced
this pull request
Jun 19, 2018
* Convert hashes into parameters Ensure `ActionController::Parameters#transform_values` and `ActionController::Parameters#transform_values!` converts hashes into parameters. * fixup! Convert hashes into parameters [Rafael Mendonça França + Kevin Sjöberg]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request to Rails, be gentle. 🙂
Summary
Ensure
ActionController::Parameters#transform_valuesandActionController::Parameters#transform_values!converts hashes intoparameters.
Closes #33044.
Other Information