Add/Remove require
#33078
Merged
Add/Remove require
#33078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `activesupport/multibyte_normalization_conformance_test.rb` `fileutils`, `tmpdir`, and `open-uri` are unused since c245ca3, c245ca3, and 7d7c2d1 in accordance. - `activesupport/test/multibyte_conformance_test.rb` `tmpdir`, and `open-uri` are unused since c245ca3, and 7d7c2d1 in accordance. Remove using of `fileutils` since c245ca3. - `activesupport/test/multibyte_grapheme_break_conformance_test.rb` `fileutils`, `tmpdir`, and `open-uri` are unused since c245ca3, c245ca3, and 7d7c2d1 in accordance.
`activesupport/test/logger_test.rb` requires `tmpdir`. `activesupport/test/multibyte_test_helpers.rb` requires `filutils`, `open-uri`, and `tmpdir`.
|
(@rails-bot has picked a reviewer for you, use r? to override) |
|
One of the tests is failing on CI. |
|
Hm, I'm seeing this kind of failure on |
|
This failure should be temporary fixed by 691addb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused
requireactivesupport/multibyte_normalization_conformance_test.rbfileutils,tmpdir, andopen-uriare unused since c245ca3, c245ca3, and 7d7c2d1 in accordance.activesupport/test/multibyte_conformance_test.rbtmpdir, andopen-uriare unused since c245ca3, and 7d7c2d1 in accordance.Remove using of
fileutilssince c245ca3.activesupport/test/multibyte_grapheme_break_conformance_test.rbfileutils,tmpdir, andopen-uriare unused since c245ca3, c245ca3, and 7d7c2d1 in accordance.Add missing
requireactivesupport/test/logger_test.rbrequirestmpdir.activesupport/test/multibyte_test_helpers.rbrequiresfilutils,open-uri, andtmpdir.