Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuring guide is missing some rails 5.2 options #33170

Closed
thomasdziedzic-pd opened this issue Jun 20, 2018 · 4 comments
Closed

configuring guide is missing some rails 5.2 options #33170

thomasdziedzic-pd opened this issue Jun 20, 2018 · 4 comments

Comments

@thomasdziedzic-pd
Copy link
Contributor

When I look at this page: http://guides.rubyonrails.org/configuring.html

It seems to be missing an option for Rails.application.config.active_support.use_authenticated_message_encryption which is new in rails 5.2.

It also says that config.action_dispatch.use_authenticated_cookie_encryption is set to false by default. But in my config/initializers/new_framework_defaults_5_2.rb it lists Rails.application.config.action_dispatch.use_authenticated_cookie_encryption = true as the default.

@utilum
Copy link
Contributor

utilum commented Jun 20, 2018

That use_authenticated_cookie_encryption is set to true by default has been fixed (c8a22bb) in master, see: http://edgeguides.rubyonrails.org/configuring.html#configuring-action-dispatch. Needs a backport?

use_authenticated_message_encryption has not been updated.

@utilum
Copy link
Contributor

utilum commented Jun 20, 2018

Would you care to make a PR, @thomasdziedzic-pd ?

@thomasdziedzic-pd
Copy link
Contributor Author

Sure, do I just add it into the 5-2-stable branch?

@utilum
Copy link
Contributor

utilum commented Jun 20, 2018

It is usually best to make changes in master, and one of the two missing data you've reported is missing there. So I would suggest fixing that in master and then backporting to 5-2-stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants