Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Storage: Explicit form field in basic example #33198

Merged
merged 1 commit into from Jun 22, 2018

Conversation

henrik
Copy link
Contributor

@henrik henrik commented Jun 22, 2018

There was an example of the controller code but not the view code. This also made me uncertain whether Active Storage supported to-server uploads or just direct-to-S3. Turns out to-server works.

Also fix syntax highlighting in the more advanced JS example.

Also fix syntax highlighting in the more advanced JS example.
@rails-bot
Copy link

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

Copy link
Contributor

@bogdanvlviv bogdanvlviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the Pull Request. LGTM.
Could you please add [ci skip] to a commit message next time when committing to Rails documentation(http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#contributing-to-the-rails-documentation) in order to skip tests execution.

@henrik
Copy link
Contributor Author

henrik commented Jun 22, 2018

Will try to remember; cheers!

@georgeclaghorn georgeclaghorn merged commit 484f970 into rails:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants