Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cache :redis_store increment/decrement ttl check and add more tests. #33264

Merged
merged 1 commit into from Jun 30, 2018

Conversation

huacnlee
Copy link
Contributor

@huacnlee huacnlee commented Jun 30, 2018

2018-06-30 12 24 51

Sorry @rafaelfranca, last PR #33254 have a mistake, ttl result:

  • returns -2 if the key does not exist.
  • returns -1 if the key exists but has no associated expire.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kamipo kamipo merged commit d106273 into rails:master Jun 30, 2018
@huacnlee huacnlee deleted the fix-redis-incr-ttl-check branch June 30, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants