Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop offense introduced in 161ed37 #33319

Merged
merged 1 commit into from
Jul 8, 2018

Conversation

bogdanvlviv
Copy link
Contributor

We prefer double quotes over single quotes.

Fixes:

railties/lib/rails/commands/server/server_command.rb:279:39:
C: Style/StringLiterals: Prefer double-quoted strings unless you need
single quotes to avoi d extra backslashes for escaping.
            original_options.concat [ '-u', using ]

Related to 161ed37

See https://codeclimate.com/github/rails/rails/issues

We prefer double quotes over single quotes.

Fixes:
```
railties/lib/rails/commands/server/server_command.rb:279:39:
C: Style/StringLiterals: Prefer double-quoted strings unless you need
single quotes to avoi d extra backslashes for escaping.
            original_options.concat [ '-u', using ]
```

Related to 161ed37
@rails-bot
Copy link

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

@kaspth
Copy link
Contributor

kaspth commented Jul 8, 2018

Doh!

@kaspth kaspth merged commit 875a06b into rails:master Jul 8, 2018
@bogdanvlviv bogdanvlviv deleted the rubocop-offense-single-quotes branch July 8, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants