Use MethodCallAssertions instead of Mocha#expects #33391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
Many calls to `Mocha#expects` preceded the introduction of `ActiveSupport::Testing::MethodCallAssertions` in 53f64c0, and many are simple to replace with `MethodCallAssertions`. This patch makes all these simple replacements. Step 5 in rails#33162
utilum
force-pushed
the
method_call_assertions_instead_of_mocha
branch
from
fbcb788
to
d0743d0
Compare
utilum
added a commit
to utilum/rails
that referenced
this pull request
Jul 22, 2018
A correct, but not obvious use of `ActiveSupport::Testing::MethodCallAssertions`, which might also have been part of rails#33337 or rails#33391.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many calls to
Mocha#expectspreceded the introduction ofActiveSupport::Testing::MethodCallAssertionsin 53f64c0,and many are simple to replace with
MethodCallAssertions.This patch makes all these simple replacements.
Step 5 in #33162