Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Active Storage instead of third-party libraries in guide #33440

Merged
merged 1 commit into from Jul 26, 2018

Conversation

pwim
Copy link
Contributor

@pwim pwim commented Jul 26, 2018

Paperclip has officially been deprecated, so we shouldn't mention it anymore.

CarrierWave could still be referenced, as there are use cases where it currently makes more sense, but for simplicity, I thought removing the mention of third party libraries made sense. If we want to talk about them, listing "alternatives" within the Active Storage guide could make more sense.

Paperclip has officially been deprecated, so we shouldn't mention it
anymore.

CarrierWave could still be referenced, as there are use cases where it
currently makes more sense, but for simplicity, I thought removing the
mention of third party libraries made sense. If we want to talk about
them, listing "alternatives" within the Active Storage guide could make
more sense.
@rails-bot
Copy link

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@kamipo kamipo merged commit 8a5fe2b into rails:master Jul 26, 2018
@kamipo
Copy link
Member

kamipo commented Jul 26, 2018

Thanks. Please make sure to add [ci skip] in a commit message in the future for doc only changes so that we can avoid running specs for doc change on Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants