cpu_time and allocations are 0 when JRuby is used #33471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kaspth (@rails-bot has picked a reviewer for you, use r? to override) |
bdewater
reviewed
Jul 30, 2018
|
Thanks for the review. Let me update the test case to handle if ruby is JRuby or CRuby. |
yahonda
force-pushed
the
follows_up_33449
branch
from
8d77b00
to
beebae0
Compare
kamipo
reviewed
Jul 30, 2018
| @@ -80,10 +80,15 @@ def test_event_attributes | |||
| instrument "some_event.my_log_subscriber" | |||
| wait | |||
| event = @log_subscriber.event | |||
| if defined?(JRUBY_VERSION) | |||
| assert_operator event.cpu_time, :>=, 0 | |||
| assert_operator event.allocations, :>=, 0 | |||
There was a problem hiding this comment.
cpu_time and allocations always return 0, so assert_equal 0, ... is preferable.
There was a problem hiding this comment.
Thanks for the review and useful information. Updated and squashed.
According to rails#33449 and rails#33468, cpu_time and allocations are 0 when JRuby is used. ```ruby $ ruby -v jruby 9.2.1.0-SNAPSHOT (2.5.0) 2018-07-27 13b2df5 Java HotSpot(TM) 64-Bit Server VM 25.181-b13 on 1.8.0_181-b13 [linux-x86_64] $ bundle exec ruby -w -Itest test/log_subscriber_test.rb -n test_event_attributes Run options: -n test_event_attributes --seed 6231 F Failure: SyncLogSubscriberTest#test_event_attributes [test/log_subscriber_test.rb:84]: Expected 0 to be > 0. rails test test/log_subscriber_test.rb:78 Finished in 0.018983s, 52.6791 runs/s, 105.3582 assertions/s. 1 runs, 2 assertions, 1 failures, 0 errors, 0 skips ```
yahonda
force-pushed
the
follows_up_33449
branch
from
beebae0
to
d35b06e
Compare
|
if CLOCK_PROCESS_CPUTIME_ID is implemented on jruby some day, the test will fail. @kampio ? Correct me if I'm wrong and it's just some known restriction that can never be implemented on JVM |
|
I'm not sure about the restriction, but if CLOCK_PROCESS_CPUTIME_ID is implemented on jruby some day, I think we can just revert the #33468. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to #33449 and #33468, cpu_time and allocations are 0 when JRuby is used.
This pull request addresses the following failure with JRuby.