Change references from Rake task to Rails command #33511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
|
r? @matthewd |
rafaelfranca
requested changes
Aug 1, 2018
| @@ -58,7 +58,7 @@ def to_s(options = {}) | |||
| # Used in annotations.rake | |||
| #:nodoc: | |||
| def self.notes_task_deprecation_warning | |||
| ActiveSupport::Deprecation.warn("This rake task is deprecated and will be removed in Rails 6.1. \nRefer to `rails notes --help` for more information.\n") | |||
| ActiveSupport::Deprecation.warn("This Rails command is deprecated and will be removed in Rails 6.1. \nRefer to `rails notes --help` for more information.\n") | |||
There was a problem hiding this comment.
So true... 😮 Good catch @rafaelfranca
Changing it.
This commit follows the path we started at commit #ea4f0e2 and continued at PR #33229.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit follows the path we started at commit ea4f0e2 and continued at PR #33229.
Thanks for your review!