Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the obvious typos detected by github.com/client9/misspell #33552

Merged
merged 2 commits into from
Aug 8, 2018

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Aug 8, 2018

Summary

This pull request fixes several minor typos in the source code. Although I am not a native English speaker, misspell detected obvious mistakes for us. I've fixed them except for false positives.

$ misspell .
actionmailer/test/test_helper_test.rb:293:52: "wiht" is a misspelling of "with"
activerecord/test/cases/arel/attributes/math_test.rb:9:30: "compatiable" is a misspelling of "compatible"
activerecord/test/cases/arel/attributes/math_test.rb:16:28: "compatiable" is a misspelling of "compatible"
activerecord/test/cases/arel/attributes/math_test.rb:23:30: "compatiable" is a misspelling of "compatible"
activerecord/test/cases/arel/attributes/math_test.rb:30:30: "compatiable" is a misspelling of "compatible"
activerecord/test/cases/arel/attributes/math_test.rb:37:37: "compatiable" is a misspelling of "compatible"
activerecord/test/cases/arel/attributes/math_test.rb:46:30: "compatiable" is a misspelling of "compatible"
activerecord/test/cases/arel/attributes/math_test.rb:53:28: "compatiable" is a misspelling of "compatible"
activerecord/test/cases/arel/attributes/math_test.rb:60:30: "compatiable" is a misspelling of "compatible"
activerecord/test/cases/arel/attributes/math_test.rb:67:30: "compatiable" is a misspelling of "compatible"
activerecord/test/cases/arel/attributes/math_test.rb:74:37: "compatiable" is a misspelling of "compatible"
activerecord/test/cases/arel/visitors/postgres_test.rb:218:40: "paranthesis" is a misspelling of "parenthesis"
activerecord/test/cases/arel/visitors/postgres_test.rb:244:40: "paranthesis" is a misspelling of "parenthesis"
activerecord/test/cases/arel/visitors/postgres_test.rb:270:40: "paranthesis" is a misspelling of "parenthesis"
activerecord/test/cases/arel/visitors/to_sql_test.rb:430:26: "Concatination" is a misspelling of "Contamination"
activerecord/test/cases/arel/select_manager_test.rb:281:17: "interect" is a misspelling of "interacted"
activerecord/test/cases/associations/has_and_belongs_to_many_associations_test.rb:261:10: "devels" is a misspelling of "delves"
activerecord/test/cases/associations/has_and_belongs_to_many_associations_test.rb:269:23: "devels" is a misspelling of "delves"
activerecord/test/cases/fixtures_test.rb:109:31: "aircrafts" is a misspelling of "aircraft"
activerecord/test/cases/fixtures_test.rb:110:30: "aircrafts" is a misspelling of "aircraft"
activerecord/test/cases/persistence_test.rb:1118:17: "aircrafts" is a misspelling of "aircraft"
activerecord/test/cases/relation/select_test.rb:10:29: "agrument" is a misspelling of "argument"
activesupport/test/cache/behaviors/cache_store_behavior.rb:151:25: "guarenteed" is a misspelling of "guaranteed"
railties/lib/rails/commands/server/server_command.rb:289:36: "occurences" is a misspelling of "occurrences"

Other Information

None

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@@ -278,7 +278,7 @@ def test_join_sources
@m2.where(table[:age].lt(99))
end

it "should interect two managers" do
it "should interact two managers" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intersect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks. I just re-fixed it.

@matthewd
Copy link
Member

matthewd commented Aug 8, 2018

Thanks! Individual typo fixes in unimportant places like this (comments, test names) would definitely fall afoul of our "no cosmetic changes" policy, but a single bulk correction seems worthwhile.

@matthewd matthewd merged commit 0bec7cd into rails:master Aug 8, 2018
@seratch seratch deleted the fix-obvious-typos branch August 8, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants