Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perform_or_enqueue instead of enqueue_or_perform #33568

Merged
merged 1 commit into from Aug 10, 2018

Conversation

mohitnatoo
Copy link
Contributor

Summary

The first operation that enqueue_or_perform method looks to carry out is performing the job; and when perform is false, it enqueues it.

def enqueue_or_perform(perform, job, job_data)
if perform
performed_jobs << job_data
Base.execute job.serialize
else
enqueued_jobs << job_data
end
end

Hence the method should be called perform_or_enqueue instead of enqueue_or_perform.

@rails-bot
Copy link

r? @georgeclaghorn

(@rails-bot has picked a reviewer for you, use r? to override)

@georgeclaghorn georgeclaghorn merged commit 924f443 into rails:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants