Conditionally use helper_method in Flash concern
#33569
Conversation
I was attempting to use the `flash` functionality in a `Metal`
controller. When including the `flash` concern I received the following
error:
NoMethodError: undefined method `helper_method'....
Either:
- `AbstractController::Helpers` should be a dependency of
`ActionController::Flash`
- `ActionController::Flash` should not require the existence of
`AbstractController::Helpers`.
Since my use case (set a flash and redirect) has no need for the helper
method and that is a common use case, making the dependency conditional
seemed the better option.
NOTE: This is similar to issue #21067 only the error is within Rails
itself while that issue had the error within Devise.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
CI failures seem unrelated to this PR. |
| end | ||
| helper_method type |
There was a problem hiding this comment.
We can execute
define_method(type) do
request.flash[type]
endunless #helper_method defined,
so probably fix should be like:
helper_method type if respond_to? :helper_methodThere was a problem hiding this comment.
If it makes sence, I'll send a patch to fix that?
There was a problem hiding this comment.
I assumed there is no reason for the method other than to provide as a helper method so put the conditional around both the definition and exposure of that definition. But if people use that method from within a controller then sure, seems you could do what you suggest.
There was a problem hiding this comment.
It was fixed in 7265b89.
I was attempting to use the
flashfunctionality in aMetalcontroller. When including theflashconcern I received the following error:Either:
AbstractController::Helpersshould be a dependency ofActionController::FlashActionController::Flashshould not require the existence ofAbstractController::Helpers.Since my use case (set a flash and redirect) has no need for the helper method and that is a common use case, making the dependency conditional seemed the better option.
NOTE: This is similar to issue #21067 only the error is within Rails itself while that issue had the error within Devise.