Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obsoleted method URI.unescape in activesupport/test #33627

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Fix obsoleted method URI.unescape in activesupport/test #33627

merged 1 commit into from
Aug 16, 2018

Conversation

vbrazo
Copy link
Contributor

@vbrazo vbrazo commented Aug 15, 2018

Summary

When running bundle exec rake, I was getting this warning:
/Users/someone/rails/activesupport/test/core_ext/object/to_query_test.rb:91:in 'test_hash_not_sorted_lexicographically_for_nested_structure': warning: URI.unescape is obsolete

I think this test should be using a method that isn't obsolete.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kamipo kamipo merged commit 239a5af into rails:master Aug 16, 2018
@kamipo
Copy link
Member

kamipo commented Aug 16, 2018

Thanks!

kamipo added a commit that referenced this pull request Aug 16, 2018
kamipo added a commit that referenced this pull request Dec 13, 2018
Fix obsoleted method URI.unescape in activesupport/test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants