Fix duplicate test method names #33684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kaspth (@rails-bot has picked a reviewer for you, use r? to override) |
sikachu
approved these changes
Aug 22, 2018
bogdanvlviv
reviewed
Aug 22, 2018
| @@ -1197,7 +1185,7 @@ def test_assert_performed_jobs_without_block_with_except_and_queue_options | |||
| assert_performed_jobs 1, except: HelloJob, queue: :other_queue | |||
| end | |||
|
|
|||
| def test_assert_performed_jobs_with_except_and_queue_options_failuree | |||
| def test_assert_performed_jobs_with_except_and_queue_options_failure | |||
There was a problem hiding this comment.
could you please just change the name to test_assert_performed_jobs_without_block_with_except_and_queue_options_failure
|
@utilum Good catch. We should test |
This patch corrects a duplicate method name introduced in rails#33635. Also fixes typo in method names.
utilum
force-pushed
the
remove_leftover_duplicate_test
branch
from
f8a7729
to
cade790
Compare
bogdanvlviv
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a duplicate test method name in #33635.
Also fixes typo in method names.