Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some comments to conform to the style used in other comments #33774

Merged
merged 1 commit into from
Sep 2, 2018

Conversation

sharang-d
Copy link
Contributor

@sharang-d sharang-d commented Sep 1, 2018

Summary

I went through #33770 (by @eileencodes) and I found some things I thought I could make consistent with the rest of the code in the repository. Here's my attempt to do that :)
(also fixes a small typo)

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@sharang-d
Copy link
Contributor Author

I didn't push with [ci skip] the first time so if anyone could cancel the extra build that'd be great. Sorry for the extra work!

@kamipo kamipo merged commit 2403199 into rails:master Sep 2, 2018
@sharang-d sharang-d deleted the comment-changes branch September 2, 2018 13:42
@sharang-d
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants