Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license field to gemspecs #3393

Closed
wants to merge 1 commit into from

Conversation

betamatt
Copy link
Contributor

Added license = "MIT" to all gemspecs.

Life would be simpler if all gems declared their license but currently few do. This is important information when declaring the licenses an application is dependent upon in due-diligence scenarios (such as startup funding.)

@grosser
Copy link
Contributor

grosser commented Oct 27, 2011

can the gems still be installed on old rubygems versions <-> will there e an undefined method licence= error ?

@betamatt
Copy link
Contributor Author

That's a great question. How old is necessary? I've verified that it's supported at least as far back as 1.3.6 but if you're concerned about ancient versions I can try to see how far back it can go.

@betamatt
Copy link
Contributor Author

Appears to install fine.

Created a gem with a license in the specification on rubygems 1.5.3.
Installed cleanly on rubygems 1.0.0. Was able to load the gem from irb.

@arunagw
Copy link
Member

arunagw commented Feb 14, 2012

@betamatt Your PR needs a rebase

@betamatt
Copy link
Contributor Author

@arunagw Rebased.

@arunagw
Copy link
Member

arunagw commented Feb 24, 2012

cc/ @josevalim

@rafaelfranca
Copy link
Member

This pull request cannot be automatically merged. If you want to apply this one, please rebase it against the master. I'll be glad to ask someone from the Core Team to review it. If you don't want, please close it.

Thanks.

@grosser
Copy link
Contributor

grosser commented Apr 29, 2012

the speed of progress is just breathtaking.... such a major change, just fetch and pick it :D

@arunagw
Copy link
Member

arunagw commented May 23, 2012

Rebase Rebase and Rebase... Let's Rebase again :-)

@arunagw
Copy link
Member

arunagw commented May 23, 2012

Closing this as @grosser cheery-picked the same and did a PR #6462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants