Add ActionDispatch::Session::CacheStore as a generic way of storing sessions in a cache #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essions in a cache.
| # not specified, <tt>Rails.cache</tt> will be used. | ||
| def initialize(app, options = {}) | ||
| @cache = options[:cache] || Rails.cache | ||
| options[:expire_after] ||= @cache.options[:expires_in] |
There was a problem hiding this comment.
Calling the option expire_after is ambiguous: can mean either a timestamp (after time T) as well as a duration (after N minutes).
There was a problem hiding this comment.
expire_after is what is already used internally... :( I am merging this!
|
Looks great. A subsequent patch could make the MemCacheStore wrap this, passing a |
josevalim
added a commit
that referenced
this pull request
Oct 22, 2011
Add ActionDispatch::Session::CacheStore as a generic way of storing sessions in a cache
|
Thanks @bdurand for the latest pull requests! They were very well written, tested and updated the proper guides! We hope we will see more pull requests coming from you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a new storage engine for Rails session storage that stores sessions in the Rails.cache.
This analogous to MemCacheStore but it is far more flexible in that it can use any backend that is available for Rails.cache (i.e. DalliStore, RedisStore, etc.). It also doesn't require configuring your memcached cluster twice in your environment config file.
(Note: this was originally opened in Lighthouse at https://rails.lighthouseapp.com/projects/8994/tickets/6675)