Removed invalid -X flag for pg_dump, fixes #33996

[MatthiasWinkelmann]

Summary

This fixes #33996: Currently, the db:structure:dump task for PostgreSQL uses a flag, "-X" (note capital case), that is invalid, and has (as far as I can find), never existed.

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[MatthiasWinkelmann]

I've now found the commit that added the flag: 69e0e0a. Pinging @dark-panda to maybe take a look at this.

[dark-panda]

Ah, I hadn’t noticed that, my commit was only meant to affect commands that use psql specifically, not pg_dump, pg_restore, etc. I’ll re-roll a new patch and pay more attention this time. I’ll make sure to only add it to the psql commands this time, because it does affect execution of those commands if you have certain flags enabled in your psqlrc, but obviously that shouldn’t affect other commands. Will submit a new patch shortly.

…

On Sep 27, 2018, at 12:00 AM, Matthias Winkelmann ***@***.***> wrote: I've now found the commit that added the flag: 69e0e0a. Pinging @dark-panda to maybe take a look at this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.