Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates expires_in docs #34020

Merged
merged 1 commit into from Sep 28, 2018
Merged

Updates expires_in docs #34020

merged 1 commit into from Sep 28, 2018

Conversation

tgturner
Copy link
Contributor

This PR improves the documentation around the expires_in option to clarify that it is not implicitly supported by all cache stores.

Addresses #34015

Previously the documentation for expires_in suggested that the option
was available for all cache stores. This clarifies that the behavior can
be supported, but is not always supported.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rails-bot rails-bot bot added the docs label Sep 28, 2018
@y-yagi y-yagi merged commit 3727215 into rails:master Sep 28, 2018
@y-yagi
Copy link
Member

y-yagi commented Sep 28, 2018

@tgturner Thanks!

@tgturner tgturner deleted the update-cache-docs branch September 28, 2018 23:59
@sandstrom
Copy link
Contributor

Thanks @tgturner! 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants