Generate delegation methods to named scope in the definition time #34122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
force-pushed
the
generate_relation_methods
branch
from
fcdf0ad
to
de44210
Compare
The delegation methods to named scope are defined when `method_missing` is invoked on the relation. Since rails#29301, the receiver in the named scope is changed to the relation like others (e.g. `default_scope`, etc) for consistency. Most named scopes would be delegated from relation by `method_missing`, since we don't allow scopes to be defined which conflict with instance methods on `Relation` (rails#31179). But if a named scope is defined with the same name as any method on the `superclass` (e.g. `Kernel.open`), the `method_missing` on the relation is not invoked. To address the issue, make the delegation methods to named scope is generated in the definition time. Fixes rails#34098.
kamipo
force-pushed
the
generate_relation_methods
branch
from
de44210
to
136b738
Compare
|
@kamipo do you need to backport? |
kamipo
added a commit
that referenced
this pull request
Oct 10, 2018
Generate delegation methods to named scope in the definition time
|
Yeah, backported 0fcde6d. |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
May 9, 2020
Follow up of rails#34122. Relation method call is relying on method_missing, but if `Kernel` has the same named method (e.g. `open`, etc), it will invoke Kernel's method since method_missing is not happened. To prevent that, eager generate relation methods if a method is the same name on `Kernel`. Fixes rails#39195.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delegation methods to named scope are defined when
method_missingis invoked on the relation.
Since #29301, the receiver in the named scope is changed to the relation
like others (e.g.
default_scope, etc) for consistency.Most named scopes would be delegated from relation by
method_missing,since we don't allow scopes to be defined which conflict with instance
methods on
Relation(#31179). But if a named scope is defined with thesame name as any method on the
superclass(e.g.Kernel.open), themethod_missingon the relation is not invoked.To address the issue, make the delegation methods to named scope is
generated in the definition time.
Fixes #34098.