New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array#sum extension breaks on empty Arrays #34230

Closed

loganb opened this issue Oct 16, 2018 · 1 comment

loganb commented Oct 16, 2018 •

edited by jeremy

rails/activesupport/lib/active_support/core_ext/enumerable.rb

Line 160 in e53acfd

def sum(init = nil, &block)

2.5.1 :001 > [].sum
 => 0
2.5.1 :002 > RUBY_VERSION
 => "2.5.1"

2.5.1 :021 > [].sum
Traceback (most recent call last):
        1: from (irb):21
ArgumentError (wrong number of arguments (given 1, expected 0))
2.5.1 :022 > Rails.version
 => "5.1.4"
2.5.1 :023 >

The reason is that the default arg to the extended sum method is nil and not 0.

The text was updated successfully, but these errors were encountered:

Member

jeremy commented Oct 16, 2018

Variant of #24796

jeremy closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment