Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated Gemfile missing gems on jruby #34243

Merged

Conversation

deivid-rodriguez
Copy link
Contributor

Summary

I noticed that when generating a Rails application on jruby, development and test gems are never included. On Linux in particular, that causes the generated application to fail in development because the file_watcher is configured to depend on listen, but the listen gem is not included.

This PR should fix that.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@y-yagi y-yagi merged commit 885ab06 into rails:master Oct 18, 2018
@y-yagi
Copy link
Member

y-yagi commented Oct 18, 2018

Thanks!

@deivid-rodriguez deivid-rodriguez deleted the fix_generated_gemfile_on_jruby branch October 18, 2018 11:16
eregon added a commit to eregon/rails that referenced this pull request Apr 3, 2019
* The fix is already in master since rails#34243
* See rails#35482 for the fix in Rails 5.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants