Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Fix PullRequest link on Rails 5.1 Release Notes #34293

Merged
merged 1 commit into from Oct 23, 2018

Conversation

tzmfreedom
Copy link
Contributor

Summary

The correct link for datetime_field changes is #25469.
But now, the link point to encode_special_chars. So I fixed the link.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kamipo kamipo merged commit 732e85e into rails:master Oct 23, 2018
@kamipo
Copy link
Member

kamipo commented Oct 23, 2018

Thanks!
In the future, you can add [ci skip] to your commit message for documentation-only changes to skip the Travis build.

@tzmfreedom tzmfreedom deleted the fix_prlink_upgrade_5_1 branch October 24, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants