Fixing an issue when parsing an opclass by allowing indexed column in indexdef to be wrapped up by double quotes #34498
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
ThomBian
force-pushed
the
thombian/fix-opclass-parsing
branch
from
4edc99f
to
253fe78
Compare
| @@ -124,7 +124,7 @@ def indexes(table_name) # :nodoc: | |||
|
|
|||
| # add info on sort order (only desc order is explicitly specified, asc is the default) | |||
| # and non-default opclasses | |||
| expressions.scan(/(?<column>\w+)\s?(?<opclass>\w+_ops)?\s?(?<desc>DESC)?\s?(?<nulls>NULLS (?:FIRST|LAST))?/).each do |column, opclass, desc, nulls| | |||
| expressions.scan(/(?<column>\w+\"?)\s?(?<opclass>\w+_ops)?\s?(?<desc>DESC)?\s?(?<nulls>NULLS (?:FIRST|LAST))?/).each do |column, opclass, desc, nulls| | |||
There was a problem hiding this comment.
" is not part of column name, and also \ isn't necessary.
|
|
||
| def test_wrapped_column_when_creating_gin_index | ||
| @connection.enable_extension("pg_trgm") | ||
| @connection.execute "CREATE INDEX trains_position ON trains USING gin(position gin_trgm_ops)" |
There was a problem hiding this comment.
Can you add an extra test case that mixed with default opclass like @connection.execute "CREATE INDEX trains_name_and_position ON trains USING btree(name, position text_pattern_ops)"?
in indexdef to be wrapped up by double quotes
Fixes rails#34493.
*Thomas Bianchini*
ThomBian
force-pushed
the
thombian/fix-opclass-parsing
branch
from
253fe78
to
a6e0eeb
Compare
Fixing an issue when parsing an opclass by allowing indexed column in indexdef to be wrapped up by double quotes
Fixes #34493.