Test when using MySQL exec_query returns ActiveRecord::Result all…
#34521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al3rez
force-pushed
the
mysql-exec-query-result
branch
from
a32b47f
to
d3db030
Compare
|
I wanted to come up with a more creative idea to return an empty result but I thought maybe it'd be over-engineering. So I just used simple if/else statements to avoid complexity. |
al3rez
force-pushed
the
mysql-exec-query-result
branch
from
d3db030
to
89eff2d
Compare
paracycle
reviewed
Nov 25, 2018
activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb
Outdated
Show resolved
Hide resolved
kamipo
reviewed
Nov 25, 2018
kamipo
reviewed
Nov 25, 2018
al3rez
force-pushed
the
mysql-exec-query-result
branch
from
89eff2d
to
996b084
Compare
kamipo
reviewed
Nov 25, 2018
When running `exec_query` with `INSERT` (or other write commands), MySQL returns `ActiveRecord::Result`.
al3rez
force-pushed
the
mysql-exec-query-result
branch
from
996b084
to
c0d7a27
Compare
|
Any time @eileencodes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34506 - When running
exec_querywith INSERT (or other write commands), MySQL returnsActiveRecord::Result