Support endless ranges in where #34906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
requested changes
Jan 9, 2019
| @@ -639,6 +639,16 @@ class AttributeTest < Arel::Spec | |||
| ) | |||
| end | |||
|
|
|||
| it "can be constructed with a range implicitly ending at Infinity" do | |||
| attribute = Attribute.new nil, nil | |||
| node = attribute.between(0..) | |||
There was a problem hiding this comment.
I think this will give us a syntax error on 2.5. Can you conditionalize this test so we don't get build failures on 2.5?
There was a problem hiding this comment.
Sure. The built actually failed for precisely this reason. I'll push an update tomorrow.
There was a problem hiding this comment.
@tenderlove just pushed an update.
There was a problem hiding this comment.
D'oh, what I did won't work for syntax error 🙈
I can either:
- Come up with something that would work for syntax errors.
- Leave the check as it is and replace
0..with0..nil(they're equivalent). In Rubyies pre-2.6 the latter results in anArgumentErrorexception.
@tenderlove what do you think?
gregnavis
force-pushed
the
add-endless-ranges-to-activerecord
branch
from
3a67c12
to
20b108a
Compare
sikachu
reviewed
Jan 11, 2019
| if Gem::Version.new('2.6.0') <= Gem::Version.new(RUBY_VERSION) | ||
| it "can be constructed with a range implicitly ending at Infinity" do | ||
| attribute = Attribute.new nil, nil | ||
| node = attribute.between(0..) |
There was a problem hiding this comment.
May I suggest this?
Suggested change
| node = attribute.between(0..) | |
| node = attribute.between(eval("0..")) # Use eval for compatibility with Ruby < 2.6 parser. |
This way Ruby parser in version < 2.6 will just overlook it.
There was a problem hiding this comment.
Great idea. Thanks!
gregnavis
force-pushed
the
add-endless-ranges-to-activerecord
branch
2 times, most recently
from
905d11e
to
fbccf87
Compare
sikachu
reviewed
Jan 11, 2019
This commit adds support for endless ranges, e.g. (1..), that were added in Ruby 2.6. They're functionally equivalent to explicitly specifying Float::INFINITY as the end of the range.
gregnavis
force-pushed
the
add-endless-ranges-to-activerecord
branch
from
fbccf87
to
7110dbe
Compare
|
@tenderlove @sikachu thanks for comments! The build is green now. Please have another look. |
sikachu
approved these changes
Jan 11, 2019
tenderlove
approved these changes
Jan 11, 2019
kamipo
added a commit
that referenced
this pull request
Jan 11, 2019
And support endless ranges for `not_between` like as `between`. Follow up #34906.
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Jul 14, 2019
Support endless ranges in where rails/rails#34906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds support for endless ranges, e.g.
(1..), that were added in Ruby 2.6. They're functionally equivalent to explicitly specifyingFloat::INFINITYas the end of the range.Specifically:
is equivalent to
Other Information
Only the end of a range can be omitted. Trying
(..1)results in a syntax error so there's no need to add support for implicit-Float::INFINITY.Alternative Implementation
We could modify
otherat the beginning ofbetweenand replacenilwithFloat::INFINITY(or even support-Float::INFINITY) so that there'd be no changes to conditions inifstatements below + we would be able to supportnil..1(equivalent to-Float::INFINITY..1).Please let me know if you find this preferable and I'll update the PR.