Allow using Action Mailbox on MySQL 5.5 #34956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspth
reviewed
Jan 17, 2019
| @@ -4,8 +4,11 @@ def change | |||
| t.integer :status, default: 0, null: false | |||
| t.string :message_id | |||
|
|
|||
| t.datetime :created_at, precision: 6, null: false | |||
| t.datetime :updated_at, precision: 6, null: false | |||
| if supports_datetime_with_precision? | |||
There was a problem hiding this comment.
Should we move this into the timestamps method itself? We can define a 6.0 migration version.
There was a problem hiding this comment.
I guess the precision is for MySQL 5.6+, since datetime with no precision means unlimited precision for PostgreSQL and SQLite.
If we want explicit precision for the timestamps, I'll create new PR as new migration default in Active Record.
There was a problem hiding this comment.
Yes, I think the precision is for MySQL. Well, if we could make it omit the precision on Postgres/SQLite and only add it on MySQL if the server supports it, that seems ideal to me.
There was a problem hiding this comment.
I've just implemented #34970.
kamipo
force-pushed
the
actionmailbox_datetime_precision
branch
from
f9e7c39
to
2d0bb87
Compare
Active Record still support MySQL 5.5 which doesn't support datetime with precision. https://github.com/rails/rails/blob/9e34df00039d63b5672315419e76f06f80ef3dc4/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb#L99-L101 So we should check `supports_datetime_with_precision?` on the connection.
kamipo
force-pushed
the
actionmailbox_datetime_precision
branch
from
2d0bb87
to
db077e8
Compare
rafaelfranca
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active Record still support MySQL 5.5 which doesn't support datetime
with precision.
rails/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
Lines 99 to 101 in 9e34df0
So we should check
supports_datetime_with_precision?on theconnection.