Improve execution time of railties' test #34971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How much does this buy us? |
|
As the result depends on the environment such as the network, the result is not stable, but this PR about to finish in about 35~37 minutes, while master now takes over 40 minutes. But before (as it is probably before the Action Mailbox is imported), it took about 30 minutes to complete, so I think there are probably other problems as well. I will investigate it. |
kaspth
approved these changes
Jan 24, 2019
y-yagi
force-pushed
the
improve_railties_test
branch
8 times, most recently
from
f562753
to
7ab47b6
Compare
y-yagi
force-pushed
the
improve_railties_test
branch
3 times, most recently
from
b7ac612
to
788a0e4
Compare
For avoid to affect tests. Also, `action_text:install` task execute `yarn add`. This is an expensive and should be avoided if it is not needed.
To avoid running require individually.
y-yagi
force-pushed
the
improve_railties_test
branch
from
788a0e4
to
ebf5e31
Compare
y-yagi
changed the title
|
There are improvements I'd like to try yet, but first I'd like to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following improvement.
action_text:installcontains the execution of yarn, it slows.