Avoid extra package install #35184
Merged
Avoid extra package install #35184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-yagi
force-pushed
the
avoid_extra_package_install
branch
4 times, most recently
from
8db5529
to
7cd9f60
Compare
kaspth
reviewed
Feb 7, 2019
y-yagi
force-pushed
the
avoid_extra_package_install
branch
4 times, most recently
from
8e6a3d0
to
3554e75
Compare
matthewd
reviewed
Feb 9, 2019
| "private": true, | ||
| "dependencies": { | ||
| "@rails/ujs": "file:../../../../actionview", | ||
| "@rails/webpacker": "^4.0.0-rc.7", |
There was a problem hiding this comment.
Could/should this point at the git repo instead?
y-yagi
force-pushed
the
avoid_extra_package_install
branch
from
3554e75
to
c2da060
Compare
kaspth
approved these changes
Feb 9, 2019
y-yagi
force-pushed
the
avoid_extra_package_install
branch
2 times, most recently
from
9556120
to
46d6544
Compare
Some tests are running yarn install during the test. The directory used for isolation test is not subject to yarn workspace, and it occurs because the required package is not installed. In order to avoid this, I fixed all necessary packages to be installed before run test and use symlink to `node_modules`. This is a bit complicated, as `yarn install` needs to be run in a specific directory before running the test. However, running `yarn install` every time run the test is expensive when testing locally and should be avoided.
y-yagi
force-pushed
the
avoid_extra_package_install
branch
from
24ee928
to
cd34f00
Compare
|
OK, this approach works and cut off the run time about 10 minutes.(as kaspth mentioned already :) |
matthewd
added a commit
to rails/buildkite-config
that referenced
this pull request
Feb 11, 2019
matthewd
added a commit
to rails/buildkite-config
that referenced
this pull request
Feb 11, 2019
|
Fantastic work, @y-yagi! I wonder if we could eventually make |
|
I have been running individual tests a lot these days, this patch speeds things up significantly. 🙌 |
atosbucket
added a commit
to atosbucket/rails-buildkit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are running yarn install during the test.
The directory used for the isolation test is not subject to yarn workspace, and it occurs because the required package is not installed.
In order to avoid this, I fixed all necessary packages to be installed before run test and use a symlink to
node_modules.This is a bit complicated, as
yarn installneeds to be run in a specific directory before running the test.However, running
yarn installevery time run the test is expensive when testing locally and should be avoided.