Fixes missing method path_for when using MirrorService with DiskService as the primary service
#35268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @abhaynikam. This needs a test. |
abhaynikam
force-pushed
the
35252-add-delegate-for-path-for-method
branch
4 times, most recently
from
fc81332
to
b14bb71
Compare
|
@georgeclaghorn : Added test cases. Please let me know if we should add more cases. |
abhaynikam
force-pushed
the
35252-add-delegate-for-path-for-method
branch
from
b14bb71
to
38ab8fd
Compare
| @@ -61,4 +61,8 @@ class ActiveStorage::Service::MirrorServiceTest < ActiveSupport::TestCase | |||
| @service.url(@key, expires_in: 2.minutes, disposition: :inline, filename: filename, content_type: "text/plain") | |||
| end | |||
| end | |||
|
|
|||
| test "path for file in primary service" do | |||
| assert_equal @service.primary.path_for(@key), @service.url_for(@key) | |||
There was a problem hiding this comment.
Sorry, I used url_for in my example when I meant path_for. 🤦♂️
Suggested change
| assert_equal @service.primary.path_for(@key), @service.url_for(@key) | |
| assert_equal @service.primary.path_for(@key), @service.path_for(@key) |
There was a problem hiding this comment.
Sorry. My bad. I should have checked it.
abhaynikam
force-pushed
the
35252-add-delegate-for-path-for-method
branch
from
38ab8fd
to
d3f9226
Compare
|
@georgeclaghorn : Done with the changes. |
|
Thank you! |
georgeclaghorn
added a commit
that referenced
this pull request
Feb 14, 2019
…-for-method Fixes missing method `path_for` when using MirrorService with DiskService as the primary service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #35252
@r? @georgeclaghorn
cc/ @marcusmalmberg