Deprecate LookupContext#rendered_format #35331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer depend on `rendered_format` side effects, so we can remove this method now. 馃帀
kaspth
reviewed
Feb 20, 2019
| @@ -16,6 +16,8 @@ module ActionView | |||
| # only once during the request, it speeds up all cache accesses. | |||
| class LookupContext #:nodoc: | |||
| attr_accessor :prefixes, :rendered_format | |||
| deprecate :rendered_format | |||
| deprecate :rendered_format= | |||
There was a problem hiding this comment.
The LookupContext is private API, why bother deprecating the attribute reader/writer?
There was a problem hiding this comment.
Hehe, I'll 鉁傦笍. No reason really.
There was a problem hiding this comment.
Actually I wanted to make 100% sure nobody else was calling it, and it looks like not
There was a problem hiding this comment.
Thanks for doing that @tenderlove! This is a method being used by the rabl-rails gem as we just noticed the warning on upgrading Rails. We'll work on an update to resolve the deprecation.
Is there an alternative to finding out the rendered format for an action?
There was a problem hiding this comment.
@javierjulio you should be able to get the format from the rendered_template. 62cb3ee may help. Let me know if I can help more!
oieioi
added a commit
to oieioi/view_source_map
that referenced
this pull request
Aug 20, 2019
The following items were supported. - `TemplateRenderer#render_template` has 4 arguments. (rails/rails#35031) - `PartialRenderer#render` returns `RenderedTemplate` or `CollectionTemplate` but String. (rails/rails#35076) - `LookupContext#rendered_format` is deprecated. (rails/rails#35331)
oieioi
added a commit
to oieioi/view_source_map
that referenced
this pull request
Aug 20, 2019
The following items were supported. - `TemplateRenderer#render_template` has 4 arguments. (rails/rails#35031) - `PartialRenderer#render` returns `RenderedTemplate` or `CollectionTemplate` but String. (rails/rails#35265) - `LookupContext#rendered_format` is deprecated. (rails/rails#35331)
oieioi
added a commit
to oieioi/view_source_map
that referenced
this pull request
Aug 20, 2019
- `TemplateRenderer#render_template` has 4 arguments. (rails/rails#35031) - `PartialRenderer#render` returns `RenderedTemplate` or `CollectionTemplate` but String. (rails/rails#35265) - `LookupContext#rendered_format` is deprecated. (rails/rails#35331) (https://github.com/rails/rails/pull/35265/files#diff-bd7d0105f7d1dfa41a0f3e033c2688e8L317-L324)
oieioi
added a commit
to oieioi/view_source_map
that referenced
this pull request
Aug 20, 2019
- `TemplateRenderer#render_template` has 4 arguments. (rails/rails#35031) - `PartialRenderer#render` returns `RenderedTemplate` or `CollectionTemplate` but String. (rails/rails#35265) - `LookupContext#rendered_format` is deprecated. (rails/rails#35331) (https://github.com/rails/rails/pull/35265/files#diff-bd7d0105f7d1dfa41a0f3e033c2688e8L317-L324)
oieioi
added a commit
to oieioi/view_source_map
that referenced
this pull request
Aug 20, 2019
- `TemplateRenderer#render_template` has 4 arguments. (rails/rails#35031) - `PartialRenderer#render` returns not `String` but `RenderedTemplate` or `CollectionTemplate`. (rails/rails#35265) - `LookupContext#rendered_format` is deprecated. (rails/rails#35331) (https://github.com/rails/rails/pull/35265/files#diff-bd7d0105f7d1dfa41a0f3e033c2688e8L317-L324)
oieioi
added a commit
to oieioi/view_source_map
that referenced
this pull request
Aug 20, 2019
- `TemplateRenderer#render_template` has 4 arguments. (rails/rails#35031) - `PartialRenderer#render` returns not `String` but `RenderedTemplate` or `CollectionTemplate`. (rails/rails#35265) - `LookupContext#rendered_format` is deprecated. (rails/rails#35331) (https://github.com/rails/rails/pull/35265/files#diff-bd7d0105f7d1dfa41a0f3e033c2688e8L317-L324)
oieioi
added a commit
to oieioi/view_source_map
that referenced
this pull request
Aug 20, 2019
- `TemplateRenderer#render_template` has 4 arguments. (rails/rails#35031) - `PartialRenderer#render` returns not `String` but `RenderedTemplate` or `RenderedCollection`. (rails/rails#35265) - `LookupContext#rendered_format` is deprecated. (rails/rails#35331) (https://github.com/rails/rails/pull/35265/files#diff-bd7d0105f7d1dfa41a0f3e033c2688e8L317-L324)
oieioi
added a commit
to oieioi/view_source_map
that referenced
this pull request
Aug 20, 2019
- `TemplateRenderer#render_template` has 4 arguments. (rails/rails#35031) - `PartialRenderer#render` returns not `String` but `RenderedTemplate` or `RenderedCollection`. (rails/rails#35265) - `LookupContext#rendered_format` is deprecated. (rails/rails#35331) (https://github.com/rails/rails/pull/35265/files#diff-bd7d0105f7d1dfa41a0f3e033c2688e8L317-L324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer depend on
rendered_formatside effects, so we can removethis method now. 馃帀