Ensure update_all series cares about optimistic locking
#35352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incrementing the lock version invalidates any other process's optimistic lock, which is the desired outcome: the record no longer looks the same as it did when they loaded it. |
|
If so, we need the update not only in |
|
Changed to opposite direction c14e161. |
Incrementing the lock version invalidates any other process's optimistic lock, which is the desired outcome: the record no longer looks the same as it did when they loaded it.
kamipo
force-pushed
the
update_all_doesnt_care_optimistic_locking
branch
from
c14e161
to
1d8fad6
Compare
kamipo
changed the title
update_all series doesn't care optimistic lockingupdate_all series cares about optimistic locking
Closed
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Aug 18, 2019
Ensure `update_all` series cares about optimistic locking rails/rails#35352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly updating the lock version without knowing the current version
is meaningless.