Make test_select_with_subquery_in_from_uses_original_table_name work with old SQLite3
#35375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
reviewed
Feb 23, 2019
| relation = Comment.joins(:post).select(:id).order(:id) | ||
| subquery = Comment.from(Comment.all, Comment.quoted_table_name).joins(:post).select(:id).order(:id) | ||
| subquery = Comment.from(Comment.all.distinct, Comment.quoted_table_name).joins(:post).select(:id).order(:id) |
There was a problem hiding this comment.
Can you note about that like here? We can drop the workaround if older SQLite3 support is dropped in the future.
rails/activerecord/lib/arel/visitors/mysql.rb
Lines 68 to 73 in a796de1
…k with old SQLite3 It seems that the reason why the `test_select_with_subquery_in_from_uses_original_table_name` does not pass is that the return value of `sqlite3_column_name()` is wrong due to subquery flattening. This seems to have been fixed with SQLite 3.20.0(https://sqlite.org/changes.html#version_3_20_0). But CI uses the old version(maybe 3.11.0), I added `DISTINCT` to avoid optimization by subquery flattening. Ref: https://sqlite.org/optoverview.html#flattening
y-yagi
force-pushed
the
fix_test_select_with_subquery_in_from_uses_original_table_name
branch
from
29c3588
to
619ae03
Compare
|
Passed both Travis(https://travis-ci.org/rails/rails/jobs/497367021) and buildkite(https://buildkite.com/rails/rails/builds/59012#5991b123-d333-45b3-bad2-344eabc789c4). |
y-yagi
deleted the
fix_test_select_with_subquery_in_from_uses_original_table_name
branch
kamipo
pushed a commit
that referenced
this pull request
Feb 23, 2019
…n_from_uses_original_table_name Make `test_select_with_subquery_in_from_uses_original_table_name` work with old SQLite3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the reason why the
test_select_with_subquery_in_from_uses_original_table_namedoes not pass is that the return value ofsqlite3_column_name()is wrong due to subquery flattening.This seems to have been fixed with 3.20.0(https://sqlite.org/changes.html#version_3_20_0).
But CI uses the old version(maybe 3.11.0), I added
DISTINCTto avoid optimization by subquery flattening.Ref: https://sqlite.org/optoverview.html#flattening