New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activesupport: Simplify class_attribute implementation #35454

Merged

kamipo merged 3 commits into rails:master from dylanahsmith:simplify-class-attribute

Mar 3, 2019

Contributor

dylanahsmith commented Mar 2, 2019

This is purely a refactor with the following simplifications:

Use redefine_singleton_method
Use keyword arguments
Use the default value in the initial method definition to avoid an unnecessary method redefinition

dylanahsmith added 3 commits

March 2, 2019 10:16


          activesupport(class_attribute): Use redefine_singleton_method

3810f3f


          activesupport(class_attribute): Use keyword arguments


          activesupport(class_attribute): Avoid unnecessary redefinition for de…

c5002fc

…fault

rails-bot bot added the activesupport label

kamipo merged commit dfa439e into rails:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment