Show friendly message to install action mailbox if the related table does not exist #35581
Conversation
|
Did you already have Active Storage enabled in the app you tested with? I’m not sure the error message would hit on Action Mailbox first? |
|
@kaspth No I didn't have active storage enabled. I was testing the conductor page and clicked on the Action Mailbox Inbound emails link: https://monosnap.com/file/RKUdXiXgy5fY4oAR6fGb6ksle33yRG |
| @@ -6,6 +6,8 @@ | |||
| <%= @exception.message %> | |||
| <% if defined?(ActiveStorage) && @exception.message.match?(%r{#{ActiveStorage::Blob.table_name}|#{ActiveStorage::Attachment.table_name}}) %> | |||
| To resolve this issue run: rails active_storage:install | |||
| <% if defined?(ActionMailbox) && @exception.message.match?(%r{#{ActionMailbox::InboundEmail.table_name}}) %> | |||
| To resolve this issue run: rails action_mailbox:install | |||
There was a problem hiding this comment.
Probably needs to be outdented like the line above.
|
Cool! I just wanted to make sure we didn't say that "Active Storage must be installed" for Action Mailbox being missing (yes, it's a dependency but the error should focus on Action Mailbox). |
|
If you want to convert this later to use #34788, do feel free to translate them! Perhaps as a PR to that branch? |
…does not exist - This is similar to the work done in rails#31534
prathamesh-sonpatki
force-pushed
the
action_mailbox_error
branch
from
bc7f288
to
c18166a
Compare
|
I meant after, but it wasn't clear in the message. But that's fixed now that I merged 😄 |
https://monosnap.com/file/Ped2VSD5gmjYxjp0xPzWR2BEs17Qbx