image_path without extension

[gadikotamohan]

Steps to reproduce

• Add a image helper as follows

<%= image_tag image_path("sample/olivia"), class: 'img img-raised' %>
and run in development and it works without any errors. But if I run in production I would get

F, [2019-03-17T18:36:37.568202 #25602] FATAL -- : [1c06c250-3a3e-46f4-8dbb-10686d28d26f] ActionView::Template::Error (The asset "sample/olivia" is not present in the asset pipeline.):

Expected behavior

• Should set actual path with digest / find the asset path with give name.

Actual behavior

• Throws internal server error

System configuration

Ruby version: 2.5.3

Rails version: 5.2.2

[arvind02]

I hope you meant

Rails Version - 5.2.2
Ruby Version - 2.5.3

[himanshu-myupchar]

@gadikotamohan have you precompiled the assets?

[gadikotamohan]

@gadikotamohan have you precompiled the assets?

Yes, even asset those files in the asset pipeline as well.

[gadikotamohan]

I hope you meant

Rails Version - 5.2.2
Ruby Version - 2.5.3

yes, sorry my bad corrected my post.

[rails-bot]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.
If you can still reproduce this error on the 5-2-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.

[lachlanjc]

To clarify, do you have a file with no extension? Can you say why? If the content type isn’t set correctly, won’t that be an issue for browsers as well?

[gadikotamohan]

@lachlanjc Um.. there need to be consistency of asset url helpers behavior between environment ie; when generating image path in development it is returning correct path but in production mode we get 500 error saying file is not part of asset precompile list.

This can re-produced in https://github.com/gadikotamohan/image_test project

In production mode:

In development mode

@lachlanjc I agree that it doesn't make sense to call image_path without valid extension but behavior of image_path need to be consistent by giving same/similar error even for development.

[Hermosa1127]

Steps to reproduce

• Add a image helper as follows
  FATAL -- : [1c06c250-3a3e-46f4-8dbb-10686d28d26f] ActionView::Template:: <%= image_tag image_path("sample/olivia"), class: 'img img-raised' %>
  and run in development and it works without any errors. But if I run in production I would get

F, [2019-03-17T18:36:37.568202 #25602] FATAL -- : [1c06c250-3a3e-46f4-8dbb-10686d28d26f] ActionView::Template::Error (The asset "sample/olivia" is not present in the asset pipeline.):

Expected behavior

• Should set actual path with digest / find the asset path with give name.

Actual behavior

• Throws internal server error

System configuration

Ruby version: 2.5.3

Rails version: 2.3.5("olivia/sample#"))

{
"offlinePages": [],
"savePageRequests": [
{
"creationTime": "Sun Aug 04 2019 10:18:19 GMT-0500 (Central Daylight Time)",
"id": "4762759857542978660",
"lastAttemptTime": "Wed Dec 31 1969 18:00:00 GMT-0600 (Central Standard Time)",
"namespace": "async_loading",
"onlineUrl": "http://bettermindz.com/",
"originalUrl": "",
"requestOrigin": "",
"status": "Available"
},
).<%= image_tag image_path("sample/olivia"), class: 'img img-raised' %>
).
"creationTime": "Sun Aug 04 2019 10:07:49 GMT-0500 (Central Daylight Time)",
"id": "7096744388757503707",
"lastAttemptTime": "Wed Dec 31 1969 18:00:00 GMT-0600 (Central Standard Time)",
"namespace": "async_loading",
"onlineUrl": "https://github.com/mit-plu/fiat-crypto/blob/master/Authors",
"originalUrl": "",
"requestOrigin": "",
"status": "Available"
},
{
"creationTime": "Sun Aug 04 2019 10:04:50 GMT-0500 (Central Daylight Time)",
"id": "7115742913666514860",
"lastAttemptTime": "Sun Aug 04 2019 10:18:19 GMT-0500 (Central Daylight Time)",
"namespace": "async_loading",
"onlineUrl": "http://chrome.com/",
"originalUrl": "",
"requestOrigin": "",
"status": "Available"
)
)

)

[rails-bot]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.
If you can still reproduce this error on the 6-0-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.

[namiwang]

We just encountered this issue.

I understand and agree that paths without extensions should not work. But then it's magically-working-in-development becomes a bug and should be warned at least.

[rafaelfranca]

👍 Please do investigate why there is this discrepancy between environments and open a PR.

[namiwang]

Started to jumping into the code and immediately found that path without an extension should work indeed. Now I'm confused.

rails/actionview/lib/action_view/helpers/asset_url_helper.rb

Lines 368 to 372 in 55e038c

	# image_path("edit") # => "/assets/edit"
	# image_path("edit.png") # => "/assets/edit.png"
	# image_path("icons/edit.png") # => "/assets/icons/edit.png"
	# image_path("/icons/edit.png") # => "/icons/edit.png"
	# image_path("http://www.example.com/img/edit.png") # => "http://www.example.com/img/edit.png"

[allenwu1973]

I think this is a very well known bug.
rails/sprockets-rails#305
rails/sprockets-rails#403

@namiwang you should be looking at here
https://github.com/rails/sprockets-rails/blob/master/lib/sprockets/rails/helper.rb#L77

@rafaelfranca
This is probably due to the Sprockets::Rails::HelperAssetResolvers::Manifest behavior differs from Sprockets::Rails::HelperAssetResolvers::Environment

if digest is enabled, Sprockets::Rails::HelperAssetResolvers::Manifest simply lookup file hash from a Hash (specificlly, @manifest.assets), so full file name must be supplied, or the asset would be considered missing.

In development mode, file extensions can be omitted, which is done by the logic here (find_matching_path_for_extensions):
https://github.com/rails/sprockets/blob/master/lib/sprockets/path_utils.rb#L236

An old PR suggests enfore extension check in sprockets_rails's asset_path.
https://github.com/rails/sprockets-rails/pull/461/files

I'd like to send in a PR to sprockets_rails,
but since this issue and proposed fix has been ignroed for a long time,
it'd be nice for the core team to suggest the disired direction for the fix.

[rails-bot]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.
If you can still reproduce this error on the 6-0-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.