Add attachment and attachments field generators #35805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-yagi
added a commit
to y-yagi/jbuilder
that referenced
this pull request
Apr 4, 2019
The params generation was cut out to a method in rails/rails#35805. This is to handle the attachments field. So use the method in jbuilder as well. Without this, a permit to handle arrays is not generated if attachments field is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new field generators for models
attachmentandattachmentswhich will generatehas_one_attachedandhas_many_attachedin models.It also generates file fields for each, adding
multiple: trueto has_many_attached, and renders links to the files on the show action.Hopefully this makes it a lot easier for people to get started using ActiveStorage and ActionText. 馃憤
This is similar to the addition of the
rich_textfield generators added in #35781.