Fix count(:all)
with eager loading and explicit select and order
#35850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up ebc09ed.
We've still experienced a regression for
size
(count(:all)
) witheager loading and explicit select and order when upgrading Rails to 5.1.
In that case, the eager loading enforces
distinct
to subselect butstill keep the custom select, it would cause the ORDER BY with DISTINCT
issue.
As another problem on
distinct
is enforced, the result ofcount
becomes fewer than expected if
select
is given explicitly.e.g.
As long as
distinct
is enforced, we need to care to keep the result ofcount
.This fixes both the
count
with eager loading problems.