Fix the deprecation warning about config.active_job.return_false_on_aborted_enqueue
#35873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aborted_enqueue` - It will return false in Rails 6.1 not 6.0. Also fixed the default value which is true for new applications.
👍
I know it could be confusing, but I think the docs were correct. We should talk about the default value of the configuration when no railtie code is applied, see #34855 (comment). So defaut value is We've also mentioned in the guide that |
|
@bogdanvlviv Thanks, that is good point. I will fix it. |
prathamesh-sonpatki
added a commit
to prathamesh-sonpatki/rails
that referenced
this pull request
Apr 5, 2019
See rails#35873 (comment) for reference [Prathamesh Sonpatki, bogdanvlviv]
prathamesh-sonpatki
added a commit
that referenced
this pull request
Apr 5, 2019
See #35873 (comment) for reference [Prathamesh Sonpatki, bogdanvlviv]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
value which is true for new applications.
cc @rafaelfranca