[ci-skip] Add 6.0 Release Notes for Active Record #35883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
reviewed
Apr 5, 2019
prathamesh-sonpatki
suggested changes
Apr 6, 2019
|
I think #35844 is missing. |
alexcameron89
force-pushed
the
add_ar_release_notes
branch
2 times, most recently
from
e3ac49d
to
e59b40e
Compare
|
@prathamesh-sonpatki thank you very much for the thorough review! I've updated my PR to reflect the changes. @simi Question: is the noteworthy change in #35844 that Rails 6 is compatible with |
alexcameron89
force-pushed
the
add_ar_release_notes
branch
from
e59b40e
to
ba57b76
Compare
|
@alexcameron89 it is not making AR compatible with 1.4, but actually it makes AR incompatible with |
|
@simi That makes sense, thank you for the additional context. I added it in 029da21 |
prathamesh-sonpatki
approved these changes
Apr 8, 2019
|
@alexcameron89 Can you squash the commits into one? |
simi
approved these changes
Apr 8, 2019
alexcameron89
force-pushed
the
add_ar_release_notes
branch
from
029da21
to
4416158
Compare
|
@prathamesh-sonpatki done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Rails 6.0 Release Notes to Active Record based off of the Changelog.
Thoughts related to this PR
Not knowing what specifically should be notable changes, I opted for including more than less. I'm glad to remove any that should not be included.
I also thought that it would be nice to categorize the notable changes with headers based off of major features, version bumps, or fixes. While I haven't implemented that change, I'm very glad to do so.