change t.integer
to t.bigint
where applicable
#35888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that in the association basics documentation some migration examples used
t.integer
instead oft.bigint
.This PR changes the datatype for all foreign keys examples.
Additionally, for the affected examples I increased migration version from
ActiveRecord::Migration[5.0]
toActiveRecord::Migration[5.2]
.I am not sure if this is the right value/approach, since the bigint-thing has been introduced in
5.1
(PR #26266), right?Any opinion?