Improve log messages for #insert_all / #upsert_all` etc. methods
#35892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryohashimoto
force-pushed
the
bulk_insert_logs
branch
from
7ed1f0b
to
6bb2c22
Compare
…#upsert etc. methods In rails#35077, `#insert_all` / `#upsert_all` / `#insert` / `#upsert` etc. methods are added. But Active Record logs only “Bulk Insert” log messages when they are invoked. This commit improves the log messages to use collect words for how invoked them.
ryohashimoto
force-pushed
the
bulk_insert_logs
branch
from
6bb2c22
to
54dce68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #35077,
#insert_all/#upsert_all/#insert/#upsertetc. methods are added. But Active Record logs only “Bulk Insert” log messages when they are invoked.This pull request improves the log messages to use correct words for how invoked them.
Bulk Insert (0.5.ms)Book Bulk Insert (0.5.ms)Bulk Insert (0.5.ms)Book Bulk Upsert (0.5.ms)Bulk Insert (0.5.ms)Book Insert (0.5.ms)Bulk Insert (0.5.ms)Book Upsert (0.5.ms)