Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete not user method for plugin_generator #35916

Merged
merged 1 commit into from Apr 10, 2019

Conversation

soartec-lab
Copy link
Contributor

Summary

In the following #35894, this method is forgot to delete, so I deleted it.

Other Information

There is no difference in the generated file.

Before

gem 'rails', '~> 6.0.0.beta3'
$ bin/rails plugin new blorgh --mountable
create
create  README.md
create  Rakefile
create  blorgh.gemspec
create  MIT-LICENSE
create  .gitignore
create  Gemfile
create  app
create  app/controllers/blorgh/application_controller.rb
create  app/helpers/blorgh/application_helper.rb
create  app/jobs/blorgh/application_job.rb
create  app/mailers/blorgh/application_mailer.rb
create  app/models/blorgh/application_record.rb
create  app/views/layouts/blorgh/application.html.erb
create  app/assets/images/blorgh
create  app/assets/images/blorgh/.keep
create  config/routes.rb
create  lib/blorgh.rb
create  lib/tasks/blorgh_tasks.rake
create  lib/blorgh/version.rb
create  lib/blorgh/engine.rb
create  app/assets/config/blorgh_manifest.js
create  app/assets/stylesheets/blorgh/application.css
create  bin/rails
create  test/test_helper.rb
create  test/blorgh_test.rb
append  Rakefile
create  test/integration/navigation_test.rb
vendor_app  test/dummy

After

gem 'rails', git: 'https://github.com/soartec-lab/rails', branch: 'delete_not_use_method'
$ cat Gemfile.lock
GIT
  remote: https://github.com/soartec-lab/rails
  revision: 831fa3dacb3eb1f20335748059d0e0a10dbb2b78
  branch: delete_not_use_method
・
・
・
$ bin/rails plugin new blorgh --mountable
create  
create  README.md
create  Rakefile
create  blorgh.gemspec
create  MIT-LICENSE
create  .gitignore
create  Gemfile
create  app
create  app/controllers/blorgh/application_controller.rb
create  app/helpers/blorgh/application_helper.rb
create  app/jobs/blorgh/application_job.rb
create  app/mailers/blorgh/application_mailer.rb
create  app/models/blorgh/application_record.rb
create  app/views/layouts/blorgh/application.html.erb
create  app/assets/images/blorgh
create  app/assets/images/blorgh/.keep
create  config/routes.rb
create  lib/blorgh.rb
create  lib/tasks/blorgh_tasks.rake
create  lib/blorgh/version.rb
create  lib/blorgh/engine.rb
create  app/assets/config/blorgh_manifest.js
create  app/assets/stylesheets/blorgh/application.css
create  bin/rails
create  test/test_helper.rb
create  test/blorgh_test.rb
append  Rakefile
create  test/integration/navigation_test.rb
vendor_app  test/dummy

@rails-bot rails-bot bot added the railties label Apr 10, 2019
@kamipo kamipo merged commit 43288a0 into rails:master Apr 10, 2019
@soartec-lab
Copy link
Contributor Author

Thank you merge !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants